Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serialization] Enable debugging into pickle backend #23854

Merged
merged 2 commits into from
Apr 12, 2022
Merged

[serialization] Enable debugging into pickle backend #23854

merged 2 commits into from
Apr 12, 2022

Conversation

suquark
Copy link
Member

@suquark suquark commented Apr 12, 2022 •
edited

Why are these changes needed?

This enables debugging into pickle backend when using Ray. This is very helpful when facing complicated serialization errors.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@suquark
Copy link
Member Author

suquark commented Apr 12, 2022

CI errors seem not related. I'll merge it.

@suquark suquark merged commit ef71803 into ray-project:master Apr 12, 2022
@suquark suquark deleted the debug_cloudpickle branch April 12, 2022 20:48
clarkzinzow added a commit to clarkzinzow/ray that referenced this pull request Apr 12, 2022
@clarkzinzow
Revert "[serialization] Enable debugging into pickle backend (ray-pro…
8b7eb32 
…ject#23854)"

This reverts commit ef71803.
simon-mo pushed a commit that referenced this pull request Apr 12, 2022
@clarkzinzow
Revert "[serialization] Enable debugging into pickle backend (#23854)" (
12f0dc1 
#23877)

This reverts commit ef71803.
suquark added a commit to suquark/ray that referenced this pull request Apr 13, 2022
@suquark
Revert "Revert "[serialization] Enable debugging into pickle backend (r…
3ec8cfb 
…ay-project#23854)" (ray-project#23877)"

This reverts commit 12f0dc1.
suquark added a commit to suquark/ray that referenced this pull request Apr 13, 2022
@suquark
Revert "Revert "[serialization] Enable debugging into pickle backend (r…
3d82e2d 
…ay-project#23854)" (ray-project#23877)"

This reverts commit 12f0dc1.
@suquark suquark mentioned this pull request Apr 13, 2022
Merged
6 tasks
suquark added a commit that referenced this pull request Apr 14, 2022
@suquark
Revert "Revert "[serialization] Enable debugging into pickle backend (#…
85542c9 
…23854)"(#23877)" (#23878)

* Revert "Revert "[serialization] Enable debugging into pickle backend (#23854)" (#23877)"

This reverts commit 12f0dc1.

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkzinzow clarkzinzow clarkzinzow approved these changes

Assignees

@clarkzinzow clarkzinzow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suquark @clarkzinzow