[serve] Use controller namespace when getting actors #23896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Serve gets actors using the current Ray namespace. However, the Ray namespace and the controller namespace may not match when using the
_override_controller_namespace
argument inserve.start()
. This change ensures that theget_actor()
calls inActorReplicaWrapper
use the controller namespace. This also allowsnum_replicas
to be scaled up and down properly when using_override_controller_namespace
.Related issue number
N/A
Checks
scripts/format.sh
to lint the changes in this PR.num_replicas
scales up and down correctly when using_override_controller_namespace
.