Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] [Out-of-Band Serialization: 3/3] Add out-of-band serialization. #23932

Merged
merged 3 commits into from
Apr 25, 2022
Merged

[Datasets] [Out-of-Band Serialization: 3/3] Add out-of-band serialization. #23932

merged 3 commits into from
Apr 25, 2022

Conversation

clarkzinzow
Copy link
Contributor

This PR adds support for out-of-band serialization of datasets, i.e. for serializing and deserializing datasets across Ray clusters. This PR is the final PR in a set to add such support (3/3). See the mono PR for more context.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarkzinzow clarkzinzow requested a review from jjyao as a code owner April 15, 2022 00:52
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 15, 2022
@clarkzinzow clarkzinzow force-pushed the datasets/feat/add-out-of-band-serialization branch from 05bd7fb to 46a2d1a Compare April 23, 2022 15:59
@clarkzinzow clarkzinzow force-pushed the datasets/feat/add-out-of-band-serialization branch from 46a2d1a to 3a87dcc Compare April 23, 2022 16:09
@clarkzinzow
Copy link
Contributor Author

@jianoaix this is ready for review!

jianoaix
jianoaix reviewed Apr 23, 2022
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we move to the last PR to wrap it up!

python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/dataset.py Outdated Show resolved Hide resolved
@clarkzinzow
PR feedback: orient APIs around serialization of lineage; add issue l…
f124af9 
…ink for remote function handle serialization issue.
jianoaix
jianoaix reviewed Apr 24, 2022
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nits

python/ray/data/dataset.py Outdated Show resolved Hide resolved
python/ray/data/tests/test_dataset.py Outdated Show resolved Hide resolved
@clarkzinzow clarkzinzow merged commit 3673b8c into ray-project:master Apr 25, 2022
@clarkzinzow clarkzinzow mentioned this pull request Apr 29, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@jianoaix jianoaix jianoaix approved these changes

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@jjyao jjyao Awaiting requested review from jjyao

Assignees

@ericl ericl

@jianoaix jianoaix

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clarkzinzow @ericl @jianoaix