[Serve] ensure replica reconfigure runs after allocation check #24052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iasoon
changed the title
edoakes
approved these changes
Apr 20, 2022
python/ray/serve/deployment_state.py
Outdated
Comment on lines
340
to
341
| # ensure that `reconfigure` will only be called after a response | ||
| # has been received from `is_allocated`. |
There was a problem hiding this comment.
Suggested change
| # ensure that `reconfigure` will only be called after a response | |
| # has been received from `is_allocated`. | |
| # Ensure that `reconfigure` will only be called after a response | |
| # has been received from `is_allocated`. |
nit: capitalization
please also add why we care about the ordering here
There was a problem hiding this comment.
Added a comment on that, but I find it a bit difficult to concisely explain. Feel free to nitpick it if you can think of something clearer!
|
@iasoon looks like there's a failure in the cross-language/java support: @simon-mo could you provide some guidance on what to update to fix this? |
|
I think the failure is because I used a keyword argument for the reconfigure call, I think it's fixed now |
simon-mo
approved these changes
Apr 21, 2022
8 tasks
jjyao
added a commit
that referenced
this pull request
Jun 13, 2023
Disallow STARTING -> UPDATING transition. By only updating running replicas, we don't need to worry about the ordering issue between initialize_and_get_metadata and reconfigure as show in #24052 and will make the code easier to reason about. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Disallow STARTING -> UPDATING transition. By only updating running replicas, we don't need to worry about the ordering issue between initialize_and_get_metadata and reconfigure as show in ray-project#24052 and will make the code easier to reason about. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Since remote calls provide no ordering guarantees, it could happen that
reconfiguregets called beforeis_allocatedSincereconfigurethen runs the user initialization code, the replica actor could get blocked and never provide its allocation check.This PR ensures that the allocation proof has been received before we run the replica initialization.
I believe this approach is better than handling the ordering in the calling code (in deployment_state), since that would require the controller to poll the replica in order to make progress on the initialization.
Would we want a test for this? What would that look like?
Related issue number
#24044
Checks
scripts/format.shto lint the changes in this PR.