[AIR] Refactor _get_unique_value_indices
#24144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
clarkzinzow
approved these changes
Apr 27, 2022
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
matthewdeng
reviewed
Apr 27, 2022
matthewdeng
reviewed
Apr 27, 2022
| dataset: Dataset, *columns: str | ||
| dataset: Dataset, | ||
| *columns: str, | ||
| drop_na_values: bool = False, |
There was a problem hiding this comment.
Do we need to add this if it's not being used?
There was a problem hiding this comment.
It's actually being used in the Categorizer PR! Left it in here by mistake, but if we are going to merge that as well, it doesn't really make a huge difference to keep it in.
clarkzinzow
pushed a commit
that referenced
this pull request
Apr 29, 2022
Adds a Categorizer preprocessor to automatically set the Categorical dtype on a dataset. This is useful for eg. LightGBM, which has build-in support for features with that dtype. Depends on #24144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Refactors
_get_unique_value_indices(used in Encoder preprocessors) for much improved performance with multiple columns. Also uses the same, more robust intermediary dataset format in_get_most_frequent_values(Imputers).The existing unit tests pass, and no functionality has been changed.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.