[rllib] Fix some missing f-strings #24148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed some strings should've been f-strings; this fixes them, and fixes a minor bug that was present, as a result.
silky
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst and
smorad
as code owners
silky
commented
Apr 24, 2022
| @@ -516,8 +516,8 @@ def compute_actions( | |||
| _is_training=tf.constant(False), | |||
| ) | |||
| if state_batches is not None: | |||
| for s in enumerate(state_batches): | |||
| input_dict["state_in_{i}"] = s | |||
| for i, s in enumerate(state_batches): | |||
There was a problem hiding this comment.
Note that this was a bug, I think, that is fixed by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some strings should've been f-strings; this fixes them, and
fixes a minor bug that was present, as a result.
Note that I only did this in the
rllibfolder; I didn't want to go through everything, because my regex generated a lot of false positives; but someone better with regexes could probably improve it:Why are these changes needed?
It's a bug.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.