Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Training Iteration Function for SAC #24157

Merged
merged 3 commits into from
Apr 26, 2022
Merged

[RLlib] Training Iteration Function for SAC #24157

merged 3 commits into from
Apr 26, 2022

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Why are these changes needed?

This PR introduces the DQN training iteration function to SAC.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

sven1977
sven1977 approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @ArturNiederfahrenhorst !

@sven1977 sven1977 marked this pull request as ready for review April 26, 2022 10:13
@sven1977 sven1977 merged commit f7be409 into ray-project:master Apr 26, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the SACtrainingiterationfn branch July 5, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArturNiederfahrenhorst @sven1977