[RLlib] CQL: training iteration function and new buffer API. #24166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst and
smorad
as code owners
gjoliver
reviewed
Apr 25, 2022
rllib/utils/replay_buffers/utils.py
Outdated
| > 0.0 | ||
| ) or isinstance( | ||
| replay_buffer, MultiAgentPrioritizedReplayBuffer | ||
| ): |
There was a problem hiding this comment.
raise exception if things are configured incorrectly, instead of silently skip the action?
There was a problem hiding this comment.
Not in this case, as we simply then don't want to do anything :)
If buffer doesn't support priorities, we'll ignore this call.
There was a problem hiding this comment.
Hence the comment above:
# Only update priorities if buffer supports them.
ArturNiederfahrenhorst
approved these changes
Apr 26, 2022
…training_itr # Conflicts: # rllib/agents/cql/cql.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CQL: training iteration function and new buffer API.
@ArturNiederfahrenhorst , ready for review once we have merged your SAC training iteration function PR.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.