Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] hyperopt searcher to support tune.choice([[1,2],[3,4]]). #24181

Merged
merged 7 commits into from
Apr 28, 2022
Merged

[tune] hyperopt searcher to support tune.choice([[1,2],[3,4]]). #24181

merged 7 commits into from
Apr 28, 2022

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Apr 25, 2022 •
edited

Why are these changes needed?

Have Hyperopt Searcher to support tune.choice([1,2],[3,4]) type search space.

Related issue number

Closes #24050

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Yard1
Yard1 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit.

python/ray/tune/tests/test_sample.py Show resolved Hide resolved
krfricke
krfricke reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add the simple assertion Antoni suggested. Also, can you provide a short PR description so I can use it as the commit message?

python/ray/tune/tests/test_sample.py Show resolved Hide resolved
@krfricke krfricke merged commit 576addf into ray-project:master Apr 28, 2022
@xwjiang2010 xwjiang2010 deleted the tuner branch July 26, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@krfricke krfricke krfricke left review comments

Assignees

@Yard1 Yard1

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tune] Tune convert search space incorrectly into HyperOpt search space
3 participants
@xwjiang2010 @Yard1 @krfricke