Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kuberay] Test Ray client and update autoscaler image #24195

Conversation

DmitriGekhtman
Copy link
Contributor

@DmitriGekhtman DmitriGekhtman commented Apr 26, 2022

Why are these changes needed?

This PR adds KubeRay e2e testing for Ray client and updates the suggested autoscaler image to one running the merge commit of PR #23883 .

In more detail, the PR does these things:

  • Adds Ray client and dashboard ports to the head service in the example config
  • Adds basic testing for Ray client, by modifying the GPU test from #23883 to submit tasks with Ray client
  • Updates the autoscaler image to the one from this PR
  • Documents context on why we're currently pinning this image
  • Allows specifying the autoscaler image in the e2e test
    • I used this to confirm that the pinned autoscaler image is compatible with all Ray images since Ray 1.11.0 -- Ray 1.11.0, Ray 1.11.1 (soon to be released), Ray 1.12.0, and Ray 1.12.1 (soon to be released).

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • e2e tests

@DmitriGekhtman DmitriGekhtman added kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side infra autoscaler, ray client, kuberay, related issues labels Apr 26, 2022
@DmitriGekhtman DmitriGekhtman added this to the Infra Backlog milestone Apr 26, 2022
@Jeffwan
Copy link
Contributor

Jeffwan commented Apr 26, 2022

The change looks good to me!

@DmitriGekhtman
Copy link
Contributor Author

The change looks good to me!

Thanks for reviewing!

.buildkite/pipeline.yml Outdated Show resolved Hide resolved
@DmitriGekhtman
Copy link
Contributor Author

Operator test passes. Test failures unrelated.

@DmitriGekhtman DmitriGekhtman merged commit d68c1ec into ray-project:master Apr 28, 2022
@DmitriGekhtman DmitriGekhtman deleted the dmitri/kuberay-job-submission-and-ray-client branch April 28, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra autoscaler, ray client, kuberay, related issues kuberay Issues for the Ray/Kuberay integration that are tracked on the Ray side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants