[Serve] Fix surprious __call__ invocation in Deployment DAG's exec_impl
#24199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
commented
Apr 26, 2022
| @@ -139,7 +139,8 @@ def _copy_impl( | |||
|
|
|||
| def _execute_impl(self, *args, **kwargs): | |||
| """Executor of DeploymentNode by ray.remote()""" | |||
| return self._deployment_handle.remote(*self._bound_args, **self._bound_kwargs) | |||
| # TODO fix comment | |||
| return self._deployment_handle | |||
There was a problem hiding this comment.
class node's impl is also broken, see 24198
jiaodong
reviewed
Apr 26, 2022
edoakes
added
the
@author-action-required
simon-mo
changed the title
__call__ invocation in Deployment DAG's exec_impl
simon-mo
removed
the
@author-action-required
jiaodong
approved these changes
Apr 27, 2022
simon-mo
commented
Apr 27, 2022
| return method_body.remote( | ||
| *self._bound_args, | ||
| **self._bound_kwargs, | ||
| ) | ||
|
|
||
| def _get_serve_deployment_handle( |
simon-mo
commented
Apr 27, 2022
| other_args_to_resolve=self._bound_other_args_to_resolve, | ||
| other_args_to_resolve={ | ||
| **self._bound_other_args_to_resolve, | ||
| PARENT_CLASS_NODE_KEY: self, |
There was a problem hiding this comment.
used by unit test, not by the actual ray dag -> serve dag translation path
There was a problem hiding this comment.
we're only passing it so DeploymentMethodNode can find method_body = getattr(self._deployment_node, self._deployment_method_name) that's essentially a deployment handle method call, do we need to include the actual instance of DeploymentNode in other_args_to_resolve ?
Given other_args_to_resolve is on critical path of DAG execution and json serde it's preferable if we add minimal info and avoid passing in Deployment or DAGNode objects if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It turns out whenever you call
dag.executeon a deployment graph, the nodes are executed recursively. When a node is executed, whatever in its_exec_implwill be called and its return value is put inparent_nodeof all its child node's_exec_impl. So this PR make sure the DeploymentNode's exec just return the handle to be used by DeploymentMethodNode's exec.Related issue number
Closes #24116
Checks
scripts/format.shto lint the changes in this PR.