Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Start building ray-ml CPU Docker image again #24266

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Apr 27, 2022

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam requested a review from krfricke as a code owner April 27, 2022 18:53
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and build seems to succeed. Thanks!

@amogkam
Copy link
Contributor Author

amogkam commented Apr 28, 2022

Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amogkam this looks good

Looks like ray-ml:nightly is still the same as ray-ml:nightly-gpu (this is the intended behavior right)!!

build-docker-images.py --py-versions py36 --device-types cpu cu101 cu102 --build-type BUILDKITE --build-base: 

These tags will be created for ray-ml:  defaultdict(<class 'list'>, {'nightly-py36-cpu': ['nightly-py36-cpu', 'ec7760-py36-cpu']})

and

build-docker-images.py --py-versions py36 --device-types cu110 cu111 cu112 --build-type BUILDKITE --build-base:

These tags will be created for ray-ml:  defaultdict(<class 'list'>, {'nightly-py36-cu112': ['nightly-py36-cu112', 'nightly-py36-gpu', 'nightly-py36', 'nightly-py36-gpu', 'ec7760-py36-cu112', 'ec7760-py36-gpu', 'ec7760-py36', 'ec7760-py36-gpu']})

Also holds for py37 & py38!

@amogkam
Copy link
Contributor Author

amogkam commented Apr 28, 2022

@ijrsvt yes this was the intention!

@amogkam amogkam merged commit 60ded3e into ray-project:master Apr 28, 2022
@amogkam amogkam deleted the build-ml-cpu-docker branch April 28, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants