[Serve] Rename input_schema to http_adapter and clarify it in doc
#24353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
changed the title
input_schema to http_adapterinput_schema to http_adapter and clarify it in doc
jiaodong
approved these changes
Apr 29, 2022
| @@ -142,7 +142,7 @@ def test_yaml_compatibility(serve_instance): | |||
| "checkpoint_cls": checkpoint_cls, | |||
| "uri": path, | |||
| }, | |||
| "input_schema": schema_func, | |||
| "http_adapter": schema_func, | |||
There was a problem hiding this comment.
schema_func -> adapter_func for this and line 130 ?
| .. code-block:: python | ||
|
|
||
| def parse_query_args(field_a: int, field_b: str): | ||
| return YourDataClass(field_a, field_b) |
There was a problem hiding this comment.
can we put up a full, short snippet here to show user what the http request look like and how its resolved by http_adapter function into YourDataClass ?
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR should be a simple rename. But I also went into to clarify the HTTP adapter documentation further.
Related issue number
Closes #24192
Checks
scripts/format.shto lint the changes in this PR.