[Serve] Unify Starlette and FastAPI JSON serialization stack #24417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
May 3, 2022
| @@ -290,6 +291,8 @@ class ASGIAppWrapper(cls): | |||
| async def __init__(self, *args, **kwargs): | |||
| super().__init__(*args, **kwargs) | |||
|
|
|||
| install_serve_encoders_to_fastapi() | |||
There was a problem hiding this comment.
makes me sad that this is in api.py -- could you move the asgiwrapper to its own (or another) file as part of this change or else a follow up?
edoakes
added
the
@author-action-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Serve always had default JSON serializer for
np.ndarrayas a quality of life feature that many users appreciate about.With introduction of FastAPI, this feature is lost. Leading to confusing error messages.
This PR fixes that by:
Related issue number
Closes #24240
Unblock #24215 (cc @krfricke)
Checks
scripts/format.shto lint the changes in this PR.