Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Deprecate outdated REST API settings #25932

Merged
merged 7 commits into from Jun 21, 2022

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

Since #25691 introduced end-to-end REST API and CLI support for the new Serve config format, the outdated format can be phased out. This change removes now-outdated fields from the config, including:

  • (Deployment-level) import_path
  • init_args
  • init_kwargs

Note that these settings can still be configured through the Python API. This change affects only Serve's REST API and CLI.

To further support this change, outdated functionality from Application is also removed, including the following methods:

  • to_dict()/from_dict()
  • to_yaml()/from_yaml()

Their functionality is moved to the few dependent pieces of code, and their implementations are removed.

Related issue number

N/A

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
      • This change relies on existing unit tests. Outdated tests are updated or removed.

@simon-mo simon-mo merged commit ad12f0c into ray-project:master Jun 21, 2022
edoakes pushed a commit to edoakes/ray that referenced this pull request Jul 14, 2022
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
Signed-off-by: Frank Luan <lsf@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants