-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Add entry to run custom test using bazel #26073
[Java] Add entry to run custom test using bazel #26073
Conversation
642332b
to
889e3b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need to change java_binary
as java_test
for all_tests
. And other changes should be checked in custom_test/
java/BUILD.bazel
Outdated
name = "all_tests", | ||
args = ["java/testng.xml"], | ||
data = ["testng.xml"], | ||
data = [ | ||
"testng_custom.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we shouldn't change this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Fixed!
0fe2a4f
to
c02e192
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jovany-wang Failed tests seem unrelated, would you please merge this PR? |
It seems some tests have been pending for a long time. @simon-mo Do you know the reason? |
Why are these changes needed?
Now we can run custom java tests by:
cp testng_custom_template.xml testng_custom.xml
testng_custom.xml
bazel test //java:custom_test --test_output=streamed