Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add entry to run custom test using bazel #26073

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

lixin-wei
Copy link
Contributor

@lixin-wei lixin-wei commented Jun 24, 2022

Why are these changes needed?

Now we can run custom java tests by:

  1. cp testng_custom_template.xml testng_custom.xml
  2. Specify test class/method in testng_custom.xml
  3. bazel test //java:custom_test --test_output=streamed

Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to change java_binary as java_test for all_tests. And other changes should be checked in custom_test/

java/BUILD.bazel Outdated
name = "all_tests",
args = ["java/testng.xml"],
data = ["testng.xml"],
data = [
"testng_custom.xml",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we shouldn't change this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Fixed!

Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lixin-wei
Copy link
Contributor Author

@jovany-wang Failed tests seem unrelated, would you please merge this PR?

@jovany-wang
Copy link
Contributor

jovany-wang commented Jun 25, 2022

@jovany-wang Failed tests seem unrelated, would you please merge this PR?

It seems some tests have been pending for a long time. @simon-mo Do you know the reason?

@jovany-wang jovany-wang merged commit c4b9e9f into ray-project:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants