[scheduler][autoscaler] Report placement resources for actor creation tasks #26813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuisawesome
changed the title
added 3 commits
August 4, 2022 20:17
ericl
reviewed
Aug 5, 2022
ericl
added
the
@author-action-required
scv119
approved these changes
Aug 5, 2022
wuisawesome
commented
Aug 5, 2022
| @@ -31,7 +31,7 @@ def test_warning_for_too_many_actors(shutdown_only): | |||
|
|
|||
| p = init_error_pubsub() | |||
|
|
|||
| @ray.remote | |||
| @ray.remote(num_cpus=0) | |||
There was a problem hiding this comment.
it appears that this test needed to be changed, because with the fixed scheduling class, these actors are getting hit by worker capping now.
wuisawesome
removed
the
@author-action-required
|
doc failures don't look related, merging. |
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
… tasks (ray-project#26813) This change makes us report placement resources for actor creation tasks. Essentially, the resource model here is that a placement resource/actor creation task is a task that runs very quickly. Closes ray-project#26806 Co-authored-by: Alex <alex@anyscale.com> Signed-off-by: Scott Graham <scgraham@microsoft.com>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
… tasks (ray-project#26813) This change makes us report placement resources for actor creation tasks. Essentially, the resource model here is that a placement resource/actor creation task is a task that runs very quickly. Closes ray-project#26806 Co-authored-by: Alex <alex@anyscale.com>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
… tasks (ray-project#26813) This change makes us report placement resources for actor creation tasks. Essentially, the resource model here is that a placement resource/actor creation task is a task that runs very quickly. Closes ray-project#26806 Co-authored-by: Alex <alex@anyscale.com> Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change makes us report placement resources for actor creation tasks. Essentially, the resource model here is that a placement resource/actor creation task is a task that runs very quickly.
Related issue number
Closes #26806
Checks
scripts/format.shto lint the changes in this PR.