-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib]: Fix torch None conversion #26863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fine with me pending tests passing. Thanks for submitting this! |
avnishn
approved these changes
Jul 22, 2022
yaxife
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 26, 2022
…h_tensor`. (ray-project#26863) Signed-off-by: nanqi.yxf <nanqi.yxf@antgroup.com>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
…h_tensor`. (ray-project#26863) Signed-off-by: klwuibm <kwu888@gmail.com>
Catch-Bull
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 27, 2022
…h_tensor`. (ray-project#26863) Signed-off-by: Catch-Bull <burglarralgrub@gmail.com>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
…h_tensor`. (ray-project#26863) Signed-off-by: Frank Luan <lsf@berkeley.edu>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…h_tensor`. (ray-project#26863) Signed-off-by: Scott Graham <scgraham@microsoft.com>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…h_tensor`. (ray-project#26863) Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch does not support
dtype=object
anymore, which is whatnp.asarray(None)
returns. This breakssave_checkpoint
andload_checkpoint
for algorithms withpytorch >= 1.12.0
.Repro script:
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.