Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpcio to 1.32.0 because we require grpc's asyncio api #28025

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

alanwguo
Copy link
Contributor

Signed-off-by: Alan Guo aguo@anyscale.com

Why are these changes needed?

fixes #28019

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Alan Guo <aguo@anyscale.com>
Signed-off-by: Alan Guo <aguo@anyscale.com>
@rkooo567
Copy link
Contributor

Hmm should we include this to 2.0.1?

@rkooo567
Copy link
Contributor

Rerunning a link check just in case

@hora-anyscale
Copy link
Contributor

IMO - yes, we should include in 2.0.1 as current docs/guidance are wrong.

cc: @zhe-thoughts

@alanwguo
Copy link
Contributor Author

alanwguo commented Sep 7, 2022

@rkooo567 please merge.

@rkooo567 rkooo567 merged commit e722c76 into ray-project:master Sep 8, 2022
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Ray 1.13.1 cannot start dashboard with grpc version 1.29.0
5 participants