Don't include script directory in sys.path if it's started via python -m #28140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arted via python -m (ray-project#28043)" (ray-project#28139)" This reverts commit e6b0d5f.
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
SongGuyang
reviewed
Aug 29, 2022
| # (e.g driver is started via `python -m`, | ||
| # see https://peps.python.org/pep-0338/), | ||
| # then we shouldn't add it to the workers. | ||
| if script_directory in sys.path: |
There was a problem hiding this comment.
If driver's sys.path doesn't include the script directory, do we need to add the current directory into sys.path by run_function_on_all_workers instead of the script directory?
There was a problem hiding this comment.
The code below adds the current directory into sys.path.
SongGuyang
approved these changes
Aug 30, 2022
JiahaoYao
pushed a commit
to JiahaoYao/ray
that referenced
this pull request
Aug 30, 2022
… -m (ray-project#28140) Redo ray-project#28043 Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
pcmoritz
pushed a commit
to pcmoritz/ray-1
that referenced
this pull request
Aug 31, 2022
… -m (ray-project#28140) Redo ray-project#28043 Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
ArturNiederfahrenhorst
pushed a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Sep 1, 2022
… -m (ray-project#28140) Redo ray-project#28043 Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
XiaodongLv
pushed a commit
to XiaodongLv/ray
that referenced
this pull request
Sep 2, 2022
… -m (ray-project#28140) Redo ray-project#28043 Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Redo #28043
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.