Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] Handle exceptions on requests failure when retrieving wheel #28685

Merged
merged 4 commits into from Oct 29, 2022
Merged

[release] Handle exceptions on requests failure when retrieving wheel #28685

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d62c827
handle exceptions on requests
rickyyx Sep 22, 2022
62b680b
nit
rickyyx Sep 22, 2022
9aa0ffc
Add unit test
Oct 29, 2022
3a8214b
Merge branch 'master' into ci/release/url-exists
Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion release/ray_release/util.py
View file
Open in desktop
Expand Up @@ -42,7 +42,11 @@ def dict_hash(dt: Dict[Any, Any]) -> str:


def url_exists(url: str) -> bool:
return requests.head(url, allow_redirects=True).status_code == 200
try:
return requests.head(url, allow_redirects=True).status_code == 200
except requests.exceptions.RequestException:
logger.exception(f"Failed to check url exists: {url}")
return False
krfricke marked this conversation as resolved.
Show resolved Hide resolved


def resolve_url(url: str) -> str:
Expand Down