[RLlib] Issue 31525: Observation Space Dict w/ Box+Discrete elements errors out. #31560
Conversation
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
| return tf1.placeholder( | ||
| shape=(None,) + ((None,) if time_axis else ()) + space.shape, | ||
| dtype=tf.float32 if space.dtype == np.float64 else space.dtype, | ||
| shape=(None,) + ((None,) if time_axis else ()) + shape[1:], |
There was a problem hiding this comment.
why are we skipping that first index of that shape returned from the action?
There was a problem hiding this comment.
Great question. We are now getting the shape from the call to _, shape = ModelCatalog.get_action_shape(space, framework="tf", one_hot=one_hot) instead of from the space directly. That's why we have to cut the batch dim (which was not part of the space shape before, but it is part of the shape returned by get_action_shape).
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
stale
bot
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
Signed-off-by: sven1977 svenmika1977@gmail.com
Issue 31525: Observation Space Dict w/ Box+Discrete elements errors out.
Note that this is only an issue for framework="tf" as it is caused by a wrong placeholder being created from the mixed (box+discrete) dict observation space.
Closes #31525
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.