[core][state] Case insensitive match for string value for state API filter. #34577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Apr 19, 2023
rkooo567
added
the
@author-action-required
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
TODO |
stale
bot
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
Oops this slipped from the GA - @rkooo567 but I feel we could still get this in? Maybe add a change log in the docstring to document this like python does for each function. |
stale
bot
removed
the
stale
|
yeah I think this makes more sense! |
|
merge conflict? |
rickyyx
removed
the
@author-action-required
|
A usability improvement for state API, would be great to get this in. cc @zhe-thoughts TODO: waiting for test results. Adding |
|
Test failures unrelated. |
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ilter. (ray-project#34577) --------- Signed-off-by: Ricky Xu <xuchen727@hotmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
…ilter. (ray-project#34577) --------- Signed-off-by: Ricky Xu <xuchen727@hotmail.com>
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
…ilter. (ray-project#34577) --------- Signed-off-by: Ricky Xu <xuchen727@hotmail.com> Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ilter. (ray-project#34577) --------- Signed-off-by: Ricky Xu <xuchen727@hotmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ran into an unexpected failure on #34554, where the query changes as we changes one of the value from (
WorkertoWORKER)I think state API filtering could be less strict about case sensitivity, and I feel loosing it altogether would be ok and more usable.
I can hardly think of a usecase where case sensitivity on some fields would be useful. Of course, we could add a flag to the API to toggle this behaviour.
Related issue number
Closes #34554
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.