Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] LightningTrainer enable checkpoint full dict with FSDP strategy #34967

Conversation

woshiyyya
Copy link
Member

@woshiyyya woshiyyya commented May 2, 2023

Why are these changes needed?

In PyTorch Lightning 2.0, when using the FSDP strategy, the checkpoint does not include the model state dictionary. This PR aims to add a model unsharding logic, which gathers all model shard from workers to rank0 CPU memory.

This is a pre-request PR for FSDP LLM finetune example: #34990

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@woshiyyya woshiyyya marked this pull request as ready for review May 5, 2023 18:35
@woshiyyya woshiyyya requested a review from gjoliver May 5, 2023 18:35
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick question.

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
@gjoliver gjoliver merged commit 3be4491 into ray-project:master May 5, 2023
31 of 35 checks passed
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
…gy (ray-project#34967)

Signed-off-by: woshiyyya <xiaoyunxuan1998@gmail.com>
ddelange added a commit to ddelange/autogluon that referenced this pull request Jul 3, 2023
pytorch_lightning 2.0 support added in 2.5 ray-project/ray#34967
ray_lightning deprecated ray-project/ray#36400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants