Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLLIB] Fix configs.py for other Frameworks as torch (e.g. TF2) #35975

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

RocketRider
Copy link
Contributor

We need to set the param "framework" otherwise the default "torch" is used

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

We need to set the param "framework" otherwise the default "torch" is used

Signed-off-by: Michael Möbius <e-mail@rocketrider.eu>
@RocketRider
Copy link
Contributor Author

@ArturNiederfahrenhorst or @sven1977 you are currently working on this file. Could you look into merge it. Maybe we need to add a unit test. But should be easy as it will currently run with torch but will fail with TF2 framework.

@RocketRider RocketRider changed the title Fix configs.py for other Frameworks as torch (e.g. TF2) [RLLIB] Fix configs.py for other Frameworks as torch (e.g. TF2) Jun 1, 2023
@stale
Copy link

stale bot commented Jul 19, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jul 19, 2023
@stale
Copy link

stale bot commented Aug 11, 2023

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Aug 11, 2023
@ArturNiederfahrenhorst ArturNiederfahrenhorst added rllib-newstack and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Sep 13, 2023
Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @ArturNiederfahrenhorst !

@sven1977 sven1977 merged commit 49cd01f into ray-project:master Sep 15, 2023
37 of 41 checks passed
@marcm-ml
Copy link

closes #37413

vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants