-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLLIB] Fix configs.py for other Frameworks as torch (e.g. TF2) #35975
Conversation
We need to set the param "framework" otherwise the default "torch" is used Signed-off-by: Michael Möbius <e-mail@rocketrider.eu>
@ArturNiederfahrenhorst or @sven1977 you are currently working on this file. Could you look into merge it. Maybe we need to add a unit test. But should be easy as it will currently run with torch but will fail with TF2 framework. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix @ArturNiederfahrenhorst !
closes #37413 |
…oject#35975) Signed-off-by: Victor <vctr.y.m@example.com>
We need to set the param "framework" otherwise the default "torch" is used
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.