Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib-contrib] Alpha star #36584

Merged
merged 14 commits into from
Oct 3, 2023
Merged

[RLlib-contrib] Alpha star #36584

merged 14 commits into from
Oct 3, 2023

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Jun 20, 2023

Signed-off-by: Avnish avnishnarayan@gmail.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@avnishn
[RLlib-contrib] Alpha star
5742f1a 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Add pipeline
169d231 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Make output verbose for debugging
8df603f 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
pin gym
afb408f 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Reduce resources
53c1eb6 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Reduce resources
1a69da9 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Add example
1ec774c 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Add readme
78e0aba 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Readme
65e6699 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Fix path
4d9c715 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Merge branch 'master' of https://github.com/ray-project/ray into rlli…
92ea5f1 
…b_alphastar

Signed-off-by: Avnish <avnishnarayan@gmail.com>
@avnishn
Merge branch 'master' of https://github.com/ray-project/ray into rlli…
b4f6304 
…b_alphastar
@avnishn
Copy link
Member Author

avnishn commented Jul 13, 2023

image

kouroshHakha
kouroshHakha reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do another pass on the dependencies to make sure there is no already deprecated deps we are leaving behind?

I spotted one.

rllib_contrib/alpha_star/examples/multi-agent-cartpole-alpha-star.py Outdated
},
replay_buffer_replay_ratio=0.0,
league_builder_config={
"type": "ray.rllib.algorithms.alpha_star.league_builder.NoLeagueBuilder"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should point to alpha_start in rllib_contrib.

@avnishn
Change import path
da1e5b5 
Signed-off-by: Avnish <avnishnarayan@gmail.com>
@stale
Copy link

stale bot commented Sep 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 16, 2023
@sven1977 sven1977 self-assigned this Oct 2, 2023
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 2, 2023
@sven1977 sven1977 merged commit ce3116f into ray-project:master Oct 3, 2023
17 of 20 checks passed
@sven1977 sven1977 added rllib RLlib related issues rllib-contrib Issues related to algorithms in rllib-contrib ray 2.8 rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Oct 3, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@avnishn
[RLlib-contrib] AlphaStar. (ray-project#36584)
2acce18 
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kouroshHakha kouroshHakha kouroshHakha left review comments

@ArturNiederfahrenhorst ArturNiederfahrenhorst ArturNiederfahrenhorst approved these changes

Assignees

@sven1977 sven1977

Labels
ray 2.8 rllib RLlib related issues rllib-contrib Issues related to algorithms in rllib-contrib rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avnishn @ArturNiederfahrenhorst @kouroshHakha @sven1977