Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Remove MXNet code #37067

Merged
merged 9 commits into from
Jul 6, 2023
Merged

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Jul 4, 2023

Why are these changes needed?

Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master

Related issue number

Closes #36909.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I did a quick search and it seems like there are a few more files where MXNet is being referenced. Shall we remove the rest of them in this PR in order to close #36909?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let me do this -- I don't think the other stuff is useful either :)

@pcmoritz pcmoritz requested a review from gjoliver as a code owner July 4, 2023 04:23
@pcmoritz pcmoritz changed the title [AIR] Remove MXNet example [AIR] Remove MXNet code Jul 4, 2023
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

doc/source/ray-air/predictors.rst Outdated Show resolved Hide resolved
:dedent:
:start-after: __mxnetpredictor_signature_start__
:end-before: __mxnetpredictor_signature_end__

.. group-tab:: statsmodel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can remove tabs now since there's only one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it in to make it easier to add more examples here in the future, but happy to remove :)

pcmoritz and others added 2 commits July 5, 2023 14:40
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
@richardliaw
Copy link
Contributor

awesome!

@pcmoritz pcmoritz merged commit 98e7731 into ray-project:master Jul 6, 2023
113 of 116 checks passed
@pcmoritz pcmoritz deleted the remove-mxnet-example branch July 6, 2023 00:03
@krfricke
Copy link
Contributor

krfricke commented Jul 6, 2023

I like this cleanup. Let's also remove the gluoncv dependency?

@krfricke krfricke mentioned this pull request Jul 6, 2023
8 tasks
pcmoritz pushed a commit that referenced this pull request Jul 7, 2023
Following up from #37067, also remove the `gluoncv` dependency.
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master

Closes ray-project#36909

Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Signed-off-by: 久龙 <guyang.sgy@antfin.com>
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.

Signed-off-by: 久龙 <guyang.sgy@antfin.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master

Closes ray-project#36909

Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.

Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master

Closes ray-project#36909

Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master

Closes ray-project#36909

Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Remove references to mxnet from Ray
4 participants