-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIR] Remove MXNet code #37067
[AIR] Remove MXNet code #37067
Conversation
doc/source/_toc.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let me do this -- I don't think the other stuff is useful either :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
doc/source/ray-air/predictors.rst
Outdated
:dedent: | ||
:start-after: __mxnetpredictor_signature_start__ | ||
:end-before: __mxnetpredictor_signature_end__ | ||
|
||
.. group-tab:: statsmodel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can remove tabs now since there's only one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it in to make it easier to add more examples here in the future, but happy to remove :)
Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
awesome! |
I like this cleanup. Let's also remove the |
Following up from #37067, also remove the `gluoncv` dependency.
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master Closes ray-project#36909 Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: 久龙 <guyang.sgy@antfin.com>
Following up from ray-project#37067, also remove the `gluoncv` dependency. Signed-off-by: 久龙 <guyang.sgy@antfin.com>
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master Closes ray-project#36909 Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
Following up from ray-project#37067, also remove the `gluoncv` dependency. Signed-off-by: harborn <gangsheng.wu@intel.com>
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master Closes ray-project#36909 Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
Following up from ray-project#37067, also remove the `gluoncv` dependency.
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master Closes ray-project#36909 Co-authored-by: matthewdeng <matthew.j.deng@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Following up from ray-project#37067, also remove the `gluoncv` dependency. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
Development on MXNet has more or less ceased for more than a year now, so there is no point in supporting it going forward: https://github.com/apache/mxnet/commits/master
Related issue number
Closes #36909.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.