Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Support Arbitrary Callables #3711

Merged
merged 1 commit into from Jan 8, 2019
Merged

[tune] Support Arbitrary Callables #3711

merged 1 commit into from Jan 8, 2019

Conversation

richardliaw
Copy link
Contributor

Closes #3710 by checking for callable and logging a warning. Should not
affect prior standard behavior.

@richardliaw richardliaw mentioned this pull request Jan 7, 2019
Closed
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10656/
Test PASSed.

ericl
ericl reviewed Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this breaks tune.function() and will fail the test

ericl
ericl approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it's just for registering, seems ok then

@richardliaw richardliaw merged commit 3331950 into ray-project:master Jan 8, 2019
@richardliaw richardliaw deleted the tune_callable branch January 8, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tune[ partial function cannot be registered as trainable
3 participants
@richardliaw @AmplabJenkins @ericl