[Data] Add Dataset.to_dask() parameter to toggle consistent metadata check
#37163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <sjl@anyscale.com>
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani and
raulchen
as code owners
Signed-off-by: Scott Lee <sjl@anyscale.com>
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 24, 2023
…a check (ray-project#37163) Currently, `Dataset.to_dask()` checks that the metadata be consistent across resulting partitions, via `DaskDataFrame.from_delayed(verify_meta=True)`. This can sometimes raise errors such as ``` ValueError: Metadata mismatch found in `from_delayed`. ``` To improve flexibility in using the method, we expose the `verify_meta` parameter to `Dataset.to_dask()`, which allows the user to skip the aforementioned metadata check. Signed-off-by: Scott Lee <sjl@anyscale.com>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…a check (ray-project#37163) Currently, `Dataset.to_dask()` checks that the metadata be consistent across resulting partitions, via `DaskDataFrame.from_delayed(verify_meta=True)`. This can sometimes raise errors such as ``` ValueError: Metadata mismatch found in `from_delayed`. ``` To improve flexibility in using the method, we expose the `verify_meta` parameter to `Dataset.to_dask()`, which allows the user to skip the aforementioned metadata check. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…a check (ray-project#37163) Currently, `Dataset.to_dask()` checks that the metadata be consistent across resulting partitions, via `DaskDataFrame.from_delayed(verify_meta=True)`. This can sometimes raise errors such as ``` ValueError: Metadata mismatch found in `from_delayed`. ``` To improve flexibility in using the method, we expose the `verify_meta` parameter to `Dataset.to_dask()`, which allows the user to skip the aforementioned metadata check. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…a check (ray-project#37163) Currently, `Dataset.to_dask()` checks that the metadata be consistent across resulting partitions, via `DaskDataFrame.from_delayed(verify_meta=True)`. This can sometimes raise errors such as ``` ValueError: Metadata mismatch found in `from_delayed`. ``` To improve flexibility in using the method, we expose the `verify_meta` parameter to `Dataset.to_dask()`, which allows the user to skip the aforementioned metadata check. Signed-off-by: Scott Lee <sjl@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…a check (ray-project#37163) Currently, `Dataset.to_dask()` checks that the metadata be consistent across resulting partitions, via `DaskDataFrame.from_delayed(verify_meta=True)`. This can sometimes raise errors such as ``` ValueError: Metadata mismatch found in `from_delayed`. ``` To improve flexibility in using the method, we expose the `verify_meta` parameter to `Dataset.to_dask()`, which allows the user to skip the aforementioned metadata check. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently,
Dataset.to_dask()checks that the metadata be consistent across resulting partitions, viaDaskDataFrame.from_delayed(verify_meta=True). This can sometimes raise errors such asTo improve flexibility in using the method, we expose the
verify_metaparameter toDataset.to_dask(), which allows the user to skip the aforementioned metadata check.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.