Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR][Docs] Remove BatchPredictor from examples #37178

Merged
merged 9 commits into from
Jul 10, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jul 7, 2023

Why are these changes needed?

#36947 deprecated BatchPredictor. This PR removes or updates references to BatchPredictor in the AIR examples.

The following examples already use updated APIs:

  • Stable Diffusion Batch Prediction with Ray AIR
  • GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:

  • Training a model with distributed XGBoost
  • Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Related issue number

Towards #37035

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@pcmoritz
Copy link
Contributor

pcmoritz commented Jul 7, 2023

Thanks a lot for doing this ❤️

Do you think all the removed material is already covered in the Ray Data batch inference docs? How about keeping some of the examples (e.g. the starter examples), just convert them to map_batches instead and also link to the batch inference docs ("if you want to learn more about batch inference, look here: ..."). This way the blow would be softened a bunch and the end-to-end nature of Ray AIR would be preserved.

Some of the stuff can probably be removed yes :)

@pcmoritz
Copy link
Contributor

pcmoritz commented Jul 7, 2023

Also curious about @richardliaw 's opinion here

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as draft July 7, 2023 01:38
@bveeramani bveeramani marked this pull request as ready for review July 7, 2023 02:14
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
…xamples2

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 10, 2023
@ericl ericl merged commit 7d1e1cf into ray-project:master Jul 10, 2023
41 of 44 checks passed
bveeramani added a commit to bveeramani/ray that referenced this pull request Jul 10, 2023
The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 11, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
bveeramani added a commit that referenced this pull request Jul 11, 2023
The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: 久龙 <guyang.sgy@antfin.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
ray-project#36947 deprecated `BatchPredictor`. This PR removes or updates references to `BatchPredictor` in the AIR examples.

The following examples already use updated APIs:
* Stable Diffusion Batch Prediction with Ray AIR
* GPT-J-6B Batch Prediction with Ray AIR (LLM)

The following examples have been updated to use updated APIs:
* Training a model with distributed XGBoost
* Training a model with distributed LightGBM

I've removed batch prediction sections from the other examples, and, where appropriate, linked to the batch inference user guide.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants