Update episode_v2.py with last_info_for #37382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vymao
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
|
@vymao Awesome! I'm all for adding this. Can you add 1-2 lines to ray/rllib/examples/custom_metrics_and_callbacks.py to illustrate and test the code path? |
|
Added an example usage. The environment in the file (Cartpole-v1) returns an empty info dict, specific custom metrics probably aren't useful here. |
Adding last_info_for method to return last info dict from the environment. This is currently present in Episode but not EpisodeV2 and is especially useful for custom environment values. Signed-off-by: Victor Mao <vctrm67@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Adding type EnvInfoDict to imports Signed-off-by: Victor Mao <vctrm67@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Signed-off-by: Victor <vctr.y.m@example.com>
…cks.py Signed-off-by: Victor <vctr.y.m@example.com>
Fixing lint Signed-off-by: Victor Mao <vctrm67@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
|
@vymao Thanks for making these changes. I've added some more code to make the example a little more colourful. |
| 0.5 * (angle - self.last_angle) + 0.5 * self._pole_angle_vel | ||
| ) | ||
| info["pole_angle_vel"] = self._pole_angle_vel | ||
| return obs, rew, term, trunc, info |
There was a problem hiding this comment.
Not strictly necessary for the example. But since we are working with the info dict here, let's also create the info our selves in order to show a more end-to-end scenario.
kouroshHakha
approved these changes
Jul 28, 2023
kouroshHakha
added
the
tests-ok
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Adding last_info_for method to return last info dict from the environment. This is currently present in Episode but not EpisodeV2 and is especially useful for custom environment values. Signed-off-by: Victor Mao <vctrm67@gmail.com> Co-authored-by: Artur Niederfahrenhorst <attaismyname@googlemail.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Adding last_info_for method to return last info dict from the environment. This is currently present in Episode but not EpisodeV2 and is especially useful for custom environment values. Signed-off-by: Victor Mao <vctrm67@gmail.com> Co-authored-by: Artur Niederfahrenhorst <attaismyname@googlemail.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Adding last_info_for method to return last info dict from the environment. This is currently present in Episode but not EpisodeV2 and is especially useful for custom environment values. Signed-off-by: Victor Mao <vctrm67@gmail.com> Co-authored-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Adding last_info_for method to return last info dict from the environment. This is currently present in Episode but not EpisodeV2 and is especially useful for custom environment values. Signed-off-by: Victor Mao <vctrm67@gmail.com> Co-authored-by: Artur Niederfahrenhorst <attaismyname@googlemail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding last_info_for method to return last info dict from the environment. This is currently present in Episode but not EpisodeV2 and is especially useful for custom environment values that can then be used in callbacks.
Related issue number
#37319
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.