Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Remove default limit on to_pandas() (#37418) #37420

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[Data] Remove default limit on to_pandas() (#37418) #37420

merged 3 commits into from
Jul 18, 2023

Conversation

crypdick
Copy link
Contributor

Why are these changes needed?

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit.

Related issue number

Closes #37418

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [x ] I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • [x ] This PR is not tested :(

Remove default limit on to_pandas() (ray-project#37418)
0ea62b6 
Signed-off-by: Richard Decal <richard.decal@ncf.edu>
@bveeramani bveeramani self-assigned this Jul 14, 2023
@bveeramani
Copy link
Member

Thanks @crypdick! Do you mind if I push changes directly to your PR?

@bveeramani
Update dataset.py
b99af89 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani changed the title Remove default limit on to_pandas() (#37418) [Data] Remove default limit on to_pandas() (#37418) Jul 14, 2023
@raulchen
Copy link
Contributor

buildkite/oss-ci-build-pr/data-tests-arrow-11 CI failure seems related. Can you take a look?

@crypdick
Copy link
Contributor Author

Thanks @crypdick! Do you mind if I push changes directly to your PR?

Yes, feel free! Sorry for the late response @bveeramani , I don't use Github often.

@bveeramani
Update dataset.py
fcfb2c5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
c21 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c21 c21 self-assigned this Jul 18, 2023
bveeramani
bveeramani approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow 11 is passing after retry, so I think it's likely flakiness.

LGTM

@c21 c21 merged commit f0c9513 into ray-project:master Jul 18, 2023
50 of 52 checks passed
@c21
Copy link
Contributor

c21 commented Jul 18, 2023

Thank you @crypdick for the contribution!

@crypdick crypdick deleted the bugfix/no-to_pandas-limit branch July 19, 2023 14:49
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
@crypdick @bveeramani @Bhav00
[Data] Remove default limit on to_pandas() (ray-project#37418) (ray…
aae2789 
…-project#37420)

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit. 

---------

Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@crypdick @bveeramani @NripeshN
[Data] Remove default limit on to_pandas() (ray-project#37418) (ray…
1ec3839 
…-project#37420)

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit.

---------

Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@crypdick @bveeramani @harborn
[Data] Remove default limit on to_pandas() (ray-project#37418) (ray…
15a82b1 
…-project#37420)

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit.

---------

Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@crypdick @bveeramani @harborn
[Data] Remove default limit on to_pandas() (ray-project#37418) (ray…
dc84ee4 
…-project#37420)

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit. 

---------

Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@crypdick @bveeramani @arvind-chandra
[Data] Remove default limit on to_pandas() (ray-project#37418) (ray…
2c92451 
…-project#37420)

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit.

---------

Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@crypdick @bveeramani
[Data] Remove default limit on to_pandas() (ray-project#37418) (ray…
a3f7c74 
…-project#37420)

Removes default hard-limit of 100k rows for dataframes, which is an unexpected and unreasonably low limit.

---------

Signed-off-by: Richard Decal <richard.decal@ncf.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@c21 c21 c21 approved these changes

@bveeramani bveeramani bveeramani approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

Assignees

@c21 c21

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] df.to_pandas() throws a ValueError with datasets >100k rows
4 participants
@crypdick @bveeramani @raulchen @c21