[AIR] Remove PredictorDeployment from examples #37457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
requested review from
richardliaw,
gjoliver,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
pcmoritz
requested review from
edoakes,
shrekris-anyscale,
sihanwang41 and
zcin
as code owners
pcmoritz
requested review from
ericl,
scv119,
c21,
scottjlee,
bveeramani,
raulchen and
a team
as code owners
pcmoritz
force-pushed
the
remove-air-predictor-deployment
branch
from
c5e78dc
to
b039fc3
Compare
pcmoritz
changed the title
matthewdeng
approved these changes
Jul 26, 2023
| @@ -159,70 +159,78 @@ def send_request(**requests_kargs): | |||
|
|
|||
|
|
|||
| def test_simple_adder(serve_instance): | |||
There was a problem hiding this comment.
Do we still need these tests? Is there anything that is being tested here that is not being covered by Predictor and Serve unit tests?
There was a problem hiding this comment.
I think it's worthwhile to test the combination of predictor deployment + serve in CI somewhere. I don't think we have anything similar in the serve unit tests at the moment.
edoakes
reviewed
Jul 26, 2023
| @@ -159,70 +159,78 @@ def send_request(**requests_kargs): | |||
|
|
|||
|
|
|||
| def test_simple_adder(serve_instance): | |||
There was a problem hiding this comment.
I think it's worthwhile to test the combination of predictor deployment + serve in CI somewhere. I don't think we have anything similar in the serve unit tests at the moment.
| predictor_cls=AdderPredictor, | ||
| @serve.deployment | ||
| class AdderDeployment: | ||
| def __init__(self, checkpoint): |
There was a problem hiding this comment.
type hints would be very nice here :)
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
This PR removes the AIR PredictorDeployment from examples and replaces them with Ray Serve deployments directly. This is more explicit and often time simpler and more understandable. It also reduces the number of ways in which things are done according to the Zen of Python `There should be one -- and preferably only one -- obvious way to do it.` Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
This PR removes the AIR PredictorDeployment from examples and replaces them with Ray Serve deployments directly. This is more explicit and often time simpler and more understandable. It also reduces the number of ways in which things are done according to the Zen of Python `There should be one -- and preferably only one -- obvious way to do it.` Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
This PR removes the AIR PredictorDeployment from examples and replaces them with Ray Serve deployments directly. This is more explicit and often time simpler and more understandable. It also reduces the number of ways in which things are done according to the Zen of Python `There should be one -- and preferably only one -- obvious way to do it.`
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
This PR removes the AIR PredictorDeployment from examples and replaces them with Ray Serve deployments directly. This is more explicit and often time simpler and more understandable. It also reduces the number of ways in which things are done according to the Zen of Python `There should be one -- and preferably only one -- obvious way to do it.` Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
This PR removes the AIR PredictorDeployment from examples and replaces them with Ray Serve deployments directly. This is more explicit and often time simpler and more understandable. It also reduces the number of ways in which things are done according to the Zen of Python `There should be one -- and preferably only one -- obvious way to do it.` Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes the AIR PredictorDeployment from examples and replaces them with Ray Serve deployments directly. This is more explicit and often time simpler and more understandable. It also reduces the number of ways in which things are done according to the Zen of Python
There should be one -- and preferably only one -- obvious way to do it..Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.