Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add agent index on first step in env runner v2 #37544

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst commented Jul 18, 2023

Why are these changes needed?

When starting a new sequence in EnvRunnerV2, we call __process_resetted_obs_for_eval to initialize it.
Unlike when we add steps after that, we don't give it an agent index.
This RP changes that.

Solves #37521

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
@kouroshHakha
Copy link
Contributor

Re-running one of the failed tests to make sure it on multiple trys.

@kouroshHakha kouroshHakha merged commit 9a131db into ray-project:master Jul 28, 2023
37 of 40 checks passed
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
…7544)

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…7544)

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…7544)

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…7544)

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…7544)

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants