[air/output] Reset heartbeat time in Ray Train after result #37569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 18, 2023 16:45
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
# Conflicts: # python/ray/tune/experimental/output.py
8 tasks
added 2 commits
July 19, 2023 11:51
# Conflicts: # python/ray/tune/experimental/output.py
woshiyyya
reviewed
Jul 20, 2023
| result: Dict, | ||
| **info, | ||
| ): | ||
| self._last_heartbeat_time = time.time() |
There was a problem hiding this comment.
Why do we reset the heartbeat time here? Is it because we already print a metric table on trial result?
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…ect#37569) Currently Ray Train prints a heartbeat every 30 seconds. However, it should only print a heartbeat if it didn't receive a result in the meantime. With this PR, we reset the heartbeat time when a result arrives. It includes a test to assert the difference between Ray Train and Ray Tune in handling this case. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ect#37569) Currently Ray Train prints a heartbeat every 30 seconds. However, it should only print a heartbeat if it didn't receive a result in the meantime. With this PR, we reset the heartbeat time when a result arrives. It includes a test to assert the difference between Ray Train and Ray Tune in handling this case. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ect#37569) Currently Ray Train prints a heartbeat every 30 seconds. However, it should only print a heartbeat if it didn't receive a result in the meantime. With this PR, we reset the heartbeat time when a result arrives. It includes a test to assert the difference between Ray Train and Ray Tune in handling this case. Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ect#37569) Currently Ray Train prints a heartbeat every 30 seconds. However, it should only print a heartbeat if it didn't receive a result in the meantime. With this PR, we reset the heartbeat time when a result arrives. It includes a test to assert the difference between Ray Train and Ray Tune in handling this case. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…ect#37569) Currently Ray Train prints a heartbeat every 30 seconds. However, it should only print a heartbeat if it didn't receive a result in the meantime. With this PR, we reset the heartbeat time when a result arrives. It includes a test to assert the difference between Ray Train and Ray Tune in handling this case. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Includes #37531.
Currently Ray Train prints a heartbeat every 30 seconds. However, it should only print a heartbeat if it didn't receive a result in the meantime.
With this PR, we reset the heartbeat time when a result arrives. It includes a test to assert the difference between Ray Train and Ray Tune in handling this case.
Related issue number
Closes #36870
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.