Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air/output] Add callback hook for trial recovery, only print error table at end #37572

Merged
merged 17 commits into from
Aug 1, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Includes #37571

This changes the context-aware output handler so that trial errors are immediately reported with their respective error files. The error table is only printed at the end.

This introduces a new callback hook, on_trial_recover which is required so error files are also available in the immediate output when a trial has a transient failure.

Two alternatives here are to either rely on the trial error handling to output the error file or to just not output the error file and wait for a full failure (on_trial_error) or experiment end to show error files for transient errors.

During training:

Trial train_f0b35_00000 errored after 0 iterations at 2023-07-19 12:18:14. Total running time: 5s
Error file: /Users/kai/ray_results/train_2023-07-19_12-18-05/train_f0b35_00000_0_always=True,fail=1_2023-07-19_12-18-09/error.txt

Only at end:

Number of errored trials: 3
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Trial name            # failures   error file                                                                                                             │
├───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ train_f0b35_00004              3   /Users/kai/ray_results/train_2023-07-19_12-18-05/train_f0b35_00004_4_always=True,fail=1_2023-07-19_12-18-09/error.txt  │
│ train_f0b35_00000              3   /Users/kai/ray_results/train_2023-07-19_12-18-05/train_f0b35_00000_0_always=True,fail=1_2023-07-19_12-18-09/error.txt  │
│ train_f0b35_00005             1*   /Users/kai/ray_results/train_2023-07-19_12-18-05/train_f0b35_00005_5_always=False,fail=1_2023-07-19_12-18-09/error.txt │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
* The trial terminated successfully after retrying.

Related issue number

Closes #36854

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 17 commits July 18, 2023 16:45
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
add
Signed-off-by: Kai Fricke <kai@anyscale.com>
# Conflicts:
#	python/ray/tune/experimental/output.py
# Conflicts:
#	python/ray/tune/experimental/output.py
@krfricke krfricke marked this pull request as ready for review July 20, 2023 16:04
@krfricke krfricke requested a review from woshiyyya July 20, 2023 16:04
@woshiyyya
Copy link
Member

woshiyyya commented Jul 21, 2023

Looks great! A few questions:

  • Can we print error files both on_trial_error and on_experiment_end?
  • Is the error file name informative? Maybe we can print the stack trace (e.g. the last 10 lines)?
  • Maybe off the topic, but currently we rewrite the error.txt and only keeps the last one. The users cannot access the previous ones. Do we have any plan to add a suffix and keep all the error_{id}.txt files?

@krfricke
Copy link
Contributor Author

Looks great! A few questions:

* Can we print error files both `on_trial_error` and  `on_experiment_end`?

On end, we get the error table.

* Is the error file name informative? Maybe we can print the stack trace (e.g. the last 10 lines)?

I should have clarified this - the regular error stacktrace is still streamed from the training worker to stderr!

* Maybe off the topic, but currently we rewrite the `error.txt` and only keeps the last one. The users cannot access the previous ones. Do we have any plan to add a suffix and keep all the `error_{id}.txt` files?

The error.txt is automatically appended, so we keep all previously caught errors automatically.

@krfricke krfricke changed the title [air/output] [rfc] Add callback hook for trial recovery, only print error table at end [air/output] Add callback hook for trial recovery, only print error table at end Jul 28, 2023
@xwjiang2010
Copy link
Contributor

Thanks! I am a fan with the footnote :)

Copy link
Member

@woshiyyya woshiyyya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kai. LGTM!

@krfricke krfricke merged commit a023f52 into ray-project:master Aug 1, 2023
70 of 73 checks passed
@krfricke krfricke deleted the air/output/recover branch August 1, 2023 07:13
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
…able at end (ray-project#37572)

This changes the context-aware output handler so that trial errors are immediately reported with their respective error files. The error table is only printed at the end.

This introduces a new callback hook, `on_trial_recover` which is required so error files are also available in the immediate output when a trial has a transient failure.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…able at end (ray-project#37572)

This changes the context-aware output handler so that trial errors are immediately reported with their respective error files. The error table is only printed at the end.

This introduces a new callback hook, `on_trial_recover` which is required so error files are also available in the immediate output when a trial has a transient failure.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…able at end (ray-project#37572)

This changes the context-aware output handler so that trial errors are immediately reported with their respective error files. The error table is only printed at the end.

This introduces a new callback hook, `on_trial_recover` which is required so error files are also available in the immediate output when a trial has a transient failure.

Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…able at end (ray-project#37572)

This changes the context-aware output handler so that trial errors are immediately reported with their respective error files. The error table is only printed at the end.

This introduces a new callback hook, `on_trial_recover` which is required so error files are also available in the immediate output when a trial has a transient failure.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…able at end (ray-project#37572)

This changes the context-aware output handler so that trial errors are immediately reported with their respective error files. The error table is only printed at the end.

This introduces a new callback hook, `on_trial_recover` which is required so error files are also available in the immediate output when a trial has a transient failure.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR output] Tune error table is a bit spammy and confusing.
3 participants