-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Train][Docs] Test code snippets in session.py
#37588
Conversation
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Let me know when tests pass?
LGTM. Seems that the tests timed out. Can we reduce the number of training steps? |
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Time out is because one of the tests requests GPUs but is run on a CPU-only node. Updated the BUILD file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Let's wait for the test to pass. Thank you Balaji!
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Many of the code snippets in session.py aren't tested, and some of them are broken. This PR fixes and tests the examples. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
Many of the code snippets in session.py aren't tested, and some of them are broken. This PR fixes and tests the examples. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
Many of the code snippets in session.py aren't tested, and some of them are broken. This PR fixes and tests the examples. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Many of the code snippets in session.py aren't tested, and some of them are broken. This PR fixes and tests the examples. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Many of the code snippets in session.py aren't tested, and some of them are broken. This PR fixes and tests the examples. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Why are these changes needed?
Many of the code snippets in
session.py
aren't tested, and some of them are broken. This PR fixes and tests the examples.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.