-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air] fix pyarrow lazy import #37670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Deng <matt@anyscale.com>
krfricke
approved these changes
Jul 25, 2023
are we cherry picking this? |
matthewdeng
added a commit
to matthewdeng/ray
that referenced
this pull request
Jul 28, 2023
ray-project#35938 introduced a pyarrow typehint, though pyarrow is being lazily imported. Signed-off-by: Matthew Deng <matt@anyscale.com>
8 tasks
rickyyx
pushed a commit
that referenced
this pull request
Jul 28, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
ray-project#35938 introduced a pyarrow typehint, though pyarrow is being lazily imported. Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
ray-project#35938 introduced a pyarrow typehint, though pyarrow is being lazily imported. Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
ray-project#35938 introduced a pyarrow typehint, though pyarrow is being lazily imported. Signed-off-by: Matthew Deng <matt@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
ray-project#35938 introduced a pyarrow typehint, though pyarrow is being lazily imported. Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
ray-project#35938 introduced a pyarrow typehint, though pyarrow is being lazily imported. Signed-off-by: Matthew Deng <matt@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#35938 introduced a
pyarrow
typehint, thoughpyarrow
is being lazily imported. This leads to the following error:Note that functionality that does rely on
pyarrow
will call the following utility function and raise a descriptive error if it is not installed:ray/python/ray/air/_internal/remote_storage.py
Lines 102 to 109 in b385a0b
Related issue number
Closes #37656
Checks
Verified locally that running
from ray import tune
succeeds.git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.