[core][autoscaler] Fix env variable overwrite not able to be used if command itself uses the env #37675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
requested review from
wuisawesome,
DmitriGekhtman,
ericl and
a team
as code owners
jjyao
approved these changes
Jul 22, 2023
rkooo567
approved these changes
Jul 22, 2023
|
TODO: should consider use https://docs.python.org/dev/library/shlex.html#shlex.quote |
scv119
approved these changes
Jul 22, 2023
|
How will we test this during release? Should we enhance the release test as well or you can test this manually for now? |
|
yeah we can test it manually for now. working on a release test concurrently, probably will be out tomorrow. |
rickyyx
added a commit
to rickyyx/ray
that referenced
this pull request
Jul 22, 2023
…command itself uses the env (ray-project#37675) --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Co-authored-by: scv119 <scv119@gmail.com>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…command itself uses the env (ray-project#37675) --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Co-authored-by: scv119 <scv119@gmail.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…command itself uses the env (ray-project#37675) --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Co-authored-by: scv119 <scv119@gmail.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…command itself uses the env (ray-project#37675) --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Co-authored-by: scv119 <scv119@gmail.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…command itself uses the env (ray-project#37675) --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Co-authored-by: scv119 <scv119@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…command itself uses the env (ray-project#37675) --------- Signed-off-by: rickyyx <rickyx@anyscale.com> Co-authored-by: scv119 <scv119@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Things will break If the command itself uses the env variable as part of command,e.g
And we preappend env overwrites with
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.