-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Add inverse transform functionality to LabelEncoder #37785
[Data] Add inverse transform functionality to LabelEncoder #37785
Conversation
178e38f
to
70f9e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Overall looks good. Just left some minor comments
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
e7b59b3
to
4af87c6
Compare
Attention: External code changedA previous version of this PR changed code that is used or cited in external sources, e.g. blog posts. It looks like these changes have been reverted or are otherwise not present in this PR anymore. Please still carefully review the changes to make sure code we use in external sources still works. |
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
4af87c6
to
f564ad9
Compare
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
…nto inverse_transform Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
360d393
to
674d1f2
Compare
Signed-off-by: Sam Hallam <sam.hallam@reverb.com>
…nto inverse_transform
Why are these changes needed?
This adds an
inverse_transform
method to theLabelEncoder
class, inspired by similar functionality in scikit-learn.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.