-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Add replica placement group support #37830
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
6223248
WIP
edoakes e8a7f9b
Merge branch 'master' of https://github.com/ray-project/ray into repl…
edoakes f57f999
Merge branch 'master' of https://github.com/ray-project/ray into repl…
edoakes 2cddb7d
fix
edoakes 9259426
fix
edoakes 5227695
basic test
edoakes 1388cae
fix
edoakes c3f3efe
fix stuff
edoakes 480216a
fix
edoakes d28861b
Merge branch 'master' of https://github.com/ray-project/ray into repl…
edoakes 513d523
fix
edoakes 8caab41
fix
edoakes 5cb9a3f
fix linter
edoakes 702b6f5
fix
edoakes 8de4726
fix
edoakes 6c89e7b
fix
edoakes 15ce708
fix
edoakes 9a4553a
pg util tests
edoakes e310c87
small fix
edoakes a3dc176
fix
edoakes ea898b4
fix
edoakes a771ba8
fix
edoakes 1a9eedd
Merge branch 'master' of https://github.com/ray-project/ray into repl…
edoakes e9949fb
fix
edoakes ef6597e
fix
edoakes e541206
add CLI support + test
edoakes 1a53810
fix
edoakes a092ea8
nit
edoakes 1722ce7
Merge branch 'master' of https://github.com/ray-project/ray into repl…
edoakes 129eebc
test case
edoakes 82b7924
fix msg
edoakes 3b75f5b
fix
edoakes 0abe3e1
make it medium
edoakes d490f59
Merge branch 'master' of https://github.com/ray-project/ray into repl…
edoakes d59f00b
skip windows
edoakes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can create a
PlacementGroupDeploymentSchedulingPolicy
that containsplacement_group_bundles
andplacement_group_strategy
and register this policy duringon_deployment_created
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought more about this and actually I don't think it changes anything related to the
DeploymentSchedulingPolicy
. The placement group is only relevant to each replica itself. We probably still want toSPREAD
the different placement groups among each other like the existing policy (and maintain things likemax_replicas_per_node
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea makes sense. Currently there is no way to spread PGs.
If you think it's a valid case, do you mind filing an enhancement issue so I can track on my side.