[Data] Enable group over multiple keys in datasets #37832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdel Jaidi <jaidisido@gmail.com>
Signed-off-by: Abdel Jaidi <jaidisido@gmail.com>
Signed-off-by: Abdel Jaidi <jaidisido@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
Signed-off-by: Anton Kukushkin <kukushkin.anton@gmail.com>
LeonLuttenberger
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani and
raulchen
as code owners
jaidisido
reviewed
Aug 14, 2023
| if ds_format == "pandas": | ||
| ds = _to_pandas(ds) | ||
|
|
||
| agg_ds = ds.groupby(["A", "B"]).count() |
There was a problem hiding this comment.
Is the .count() superfluous given that it's done again on the line below it?
There was a problem hiding this comment.
The line below just checks the row count of the result of this operation. This amounts to just checking that there were indeed 6 groups in the original frame.
raulchen
approved these changes
Oct 20, 2023
python/ray/data/_internal/planner/exchange/aggregate_task_spec.py
Outdated
Show resolved
Hide resolved
|
@LeonLuttenberger - thanks for the contribution! Shall we also add a unit test to test out Technically after this PR, |
|
Sounds good, I'm creating a PR to add the test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a first draft into enabling grouping Ray datasets over multiple keys (i.e. passing a list of keys to
.group()).A new unit test
test_groupby_multiple_keys_tabular_countshowcases an example.Depends on #37124 being merged first.
Related issue number
#25732
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.