[Data] Make iter_batches an Iterable
#37881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
requested review from
ericl,
scv119,
c21,
scottjlee,
bveeramani and
raulchen
as code owners
matthewdeng
reviewed
Jul 28, 2023
amogkam
changed the title
iter_batches a multi-use iteratoriter_batches an Iterable
c21
reviewed
Jul 28, 2023
amogkam
requested review from
richardliaw,
krfricke,
xwjiang2010,
Yard1,
maxpumperla and
a team
as code owners
matthewdeng
approved these changes
Jul 31, 2023
| @@ -37,7 +37,7 @@ def train_fn(config): | |||
| # Local worker rank on the current machine | |||
| "local_rank": session.get_local_rank(), | |||
| # Data | |||
| "data_shard": next(dataset_shard.iter_batches(batch_format="pandas")), | |||
| "data_shard": next(iter(dataset_shard.iter_batches(batch_format="pandas"))), | |||
There was a problem hiding this comment.
nit: This seems a bit weird to report, but it also doesn't look like this code block is used anywhere in the docs...
woshiyyya
reviewed
Jul 31, 2023
woshiyyya
approved these changes
Jul 31, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Make iter_batches, iter_torch_batches, iter_rows and iter_tf_batches return an Iterable instead of a single use Iterator. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Make iter_batches, iter_torch_batches, iter_rows and iter_tf_batches return an Iterable instead of a single use Iterator. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Make iter_batches, iter_torch_batches, iter_rows and iter_tf_batches return an Iterable instead of a single use Iterator. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Make iter_batches, iter_torch_batches, iter_rows and iter_tf_batches return an Iterable instead of a single use Iterator. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Make iter_batches, iter_torch_batches, iter_rows and iter_tf_batches return an Iterable instead of a single use Iterator. --------- Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
iter_batches,iter_torch_batches,iter_rowsanditer_tf_batchesreturn an Iterable instead of a single use Iterator.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.