[serve] Cherry pick fix for setting request_timeout_s in config files
#37903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekris-anyscale
added
release-blocker
shrekris-anyscale
requested review from
edoakes,
sihanwang41,
zcin,
architkulkarni and
a team
as code owners
|
@shrekris-anyscale can you include a description of what the PR does in the title please? Else the commit message isn't very useful |
edoakes
changed the title
request_timeout_s in config files
edoakes
approved these changes
Jul 28, 2023
Oh, I didn't realize that. Thanks for letting me know, I'll do that going forward. |
|
@shrekris-anyscale fix DCO |
…ay-project#37884) Currently, the Serve config's `request_timeout_s` field is ignored. This change makes Serve pass in `request_timeout_s` to the HTTP Proxies when starting up, so the field is respected. Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
shrekris-anyscale
force-pushed
the
cherry_pick_37884
branch
from
3da3dd9
to
8eb8c33
Compare
zhe-thoughts
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change cherry-picks #37884 into Ray 2.6.2.
Related issue number
Closes #37882.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.