[tune/train] Remove legacy TrialRunner/Executor #37927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 31, 2023 09:57
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
…-exec # Conflicts: # python/ray/tune/execution/trial_runner.py
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
krfricke
requested review from
richardliaw,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
With this data I'd be comfortable to proceed with this removal. |
|
Resolve conflicts? |
added 2 commits
August 3, 2023 09:11
…-exec # Conflicts: # python/ray/tune/execution/ray_trial_executor.py # python/ray/tune/tests/test_trial_runner_2.py
added 2 commits
August 3, 2023 14:24
Signed-off-by: Kai Fricke <kai@anyscale.com>
|
Stamp. Let's ship it! |
xwjiang2010
approved these changes
Aug 3, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
We've turned on the new execution engine in Ray 2.5 per default. Some last problems with BOHB have been resolved in 2.6 and we haven't received any complaints. Thus we can simplify our code base by removing the legacy trial runner/executor. Note that a number of integration tests have not been fully converted, yet. These are deactivated but still present and should be moved to the new engine. However, they currently run on the old code path anyways, so we don't lose any signal for the new execution engine when removing them. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
We've turned on the new execution engine in Ray 2.5 per default. Some last problems with BOHB have been resolved in 2.6 and we haven't received any complaints. Thus we can simplify our code base by removing the legacy trial runner/executor. Note that a number of integration tests have not been fully converted, yet. These are deactivated but still present and should be moved to the new engine. However, they currently run on the old code path anyways, so we don't lose any signal for the new execution engine when removing them. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
We've turned on the new execution engine in Ray 2.5 per default. Some last problems with BOHB have been resolved in 2.6 and we haven't received any complaints. Thus we can simplify our code base by removing the legacy trial runner/executor. Note that a number of integration tests have not been fully converted, yet. These are deactivated but still present and should be moved to the new engine. However, they currently run on the old code path anyways, so we don't lose any signal for the new execution engine when removing them. Signed-off-by: Kai Fricke <kai@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
We've turned on the new execution engine in Ray 2.5 per default. Some last problems with BOHB have been resolved in 2.6 and we haven't received any complaints. Thus we can simplify our code base by removing the legacy trial runner/executor. Note that a number of integration tests have not been fully converted, yet. These are deactivated but still present and should be moved to the new engine. However, they currently run on the old code path anyways, so we don't lose any signal for the new execution engine when removing them. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
We've turned on the new execution engine in Ray 2.5 per default. Some last problems with BOHB have been resolved in 2.6 and we haven't received any complaints. Thus we can simplify our code base by removing the legacy trial runner/executor. Note that a number of integration tests have not been fully converted, yet. These are deactivated but still present and should be moved to the new engine. However, they currently run on the old code path anyways, so we don't lose any signal for the new execution engine when removing them. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We've turned on the new execution engine in Ray 2.5 per default. Some last problems with BOHB have been resolved in 2.6 and we haven't received any complaints. Thus we can simplify our code base by removing the legacy trial runner/executor.
Note that a number of integration tests have not been fully converted, yet. These are deactivated but still present and should be moved to the new engine. However, they currently run on the old code path anyways, so we don't lose any signal for the new execution engine when removing them.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.