Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][agent] fix the race condition where the worker process terminated during the get_all_workers call #37953

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jul 31, 2023

the issue seems caused by the race condition where the work process exited between list and stats call,
this PR fixed it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 linked an issue Jul 31, 2023 that may be closed by this pull request
@scv119 scv119 merged commit 8fbdb6f into ray-project:master Aug 1, 2023
30 of 34 checks passed
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
…ted during the get_all_workers call ray-project#37953

the issue seems caused by the race condition where the work process exited between list and stats call,
this PR fixed it.

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…ted during the get_all_workers call ray-project#37953

the issue seems caused by the race condition where the work process exited between list and stats call,
this PR fixed it.

Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…ted during the get_all_workers call ray-project#37953


the issue seems caused by the race condition where the work process exited between list and stats call,
this PR fixed it.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ted during the get_all_workers call ray-project#37953

the issue seems caused by the race condition where the work process exited between list and stats call,
this PR fixed it.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ted during the get_all_workers call ray-project#37953

the issue seems caused by the race condition where the work process exited between list and stats call,
this PR fixed it.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] node crash due to agent failure
4 participants