Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Raise error if PIL can't load image #38030

Merged
merged 4 commits into from
Aug 4, 2023
Merged

[Data] Raise error if PIL can't load image #38030

merged 4 commits into from
Aug 4, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 2, 2023 •
edited
Loading

Why are these changes needed?

If you call read_images and PIL can't load a file, you get an unhelpful error message:

PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x19997c350>

This PR updates the error message to include the path to the file.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
c6023ec 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Appease lint
83cfdd9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update test_image.py
8135035 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
amogkam
amogkam approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

c21
c21 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bveeramani
Update test_image.py
a60177c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 81b1e8f into ray-project:master Aug 4, 2023
57 of 64 checks passed
@bveeramani bveeramani deleted the add-image-error branch August 4, 2023 00:22
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@bveeramani @NripeshN
[Data] Raise error if PIL can't load image (ray-project#38030)
6a84781 
If you call read_images and PIL can't load a file, you get an unhelpful error message:

> PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x19997c350>

This PR updates the error message to include the path to the file

Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@bveeramani @harborn
[Data] Raise error if PIL can't load image (ray-project#38030)
a017a42 
If you call read_images and PIL can't load a file, you get an unhelpful error message:

> PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x19997c350>

This PR updates the error message to include the path to the file

Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@bveeramani @harborn
[Data] Raise error if PIL can't load image (ray-project#38030)
4e26240 
If you call read_images and PIL can't load a file, you get an unhelpful error message:

> PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x19997c350>

This PR updates the error message to include the path to the file
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@bveeramani @arvind-chandra
[Data] Raise error if PIL can't load image (ray-project#38030)
938471b 
If you call read_images and PIL can't load a file, you get an unhelpful error message:

> PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x19997c350>

This PR updates the error message to include the path to the file

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@bveeramani
[Data] Raise error if PIL can't load image (ray-project#38030)
dd5ad4f 
If you call read_images and PIL can't load a file, you get an unhelpful error message:

> PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x19997c350>

This PR updates the error message to include the path to the file

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@amogkam amogkam amogkam approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

Assignees

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bveeramani @c21 @amogkam