Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix args and kwargs passed to ActorPool map_batches #38110

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Aug 4, 2023

Fixes args and kwargs passed to ActorPool map_batches. Closes #38092

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@amogkam amogkam merged commit 43958f0 into ray-project:master Aug 4, 2023
60 of 64 checks passed
@amogkam amogkam deleted the actorpool-kwargs branch August 4, 2023 22:50
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
…ct#38110)

Fixes args and kwargs passed to ActorPool map_batches. Closes ray-project#38092
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…ct#38110)

Fixes args and kwargs passed to ActorPool map_batches. Closes ray-project#38092
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: harborn <gangsheng.wu@intel.com>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…ct#38110)

Fixes args and kwargs passed to ActorPool map_batches. Closes ray-project#38092
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ct#38110)

Fixes args and kwargs passed to ActorPool map_batches. Closes ray-project#38092
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ct#38110)

Fixes args and kwargs passed to ActorPool map_batches. Closes ray-project#38092
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data] fn_kwargs does not work with ActorPoolStrategy
3 participants