Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add tif file extension to ImageDatasource #38129

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 4, 2023

Why are these changes needed?

tif is a valid image file extension, but read_images doesn't recognize it because it's not included in the ImageDatasource._FILE_EXTENSION list.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@scottjlee
Copy link
Contributor

Assuming that the underlying library used to read the image files supports .tif as well.

@bveeramani
Copy link
Member Author

Assuming that the underlying library used to read the image files supports .tif as well.

Yeah, PIL works with .tif.

@bveeramani bveeramani merged commit 3755c5b into ray-project:master Aug 4, 2023
58 of 64 checks passed
@bveeramani bveeramani deleted the image-extensions branch August 4, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants