Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib][docs] Cherry-pick-learner-docs-263 #38137

Merged

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented Aug 4, 2023

Signed-off-by: Avnish avnishnarayan@gmail.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Avnish <avnishnarayan@gmail.com>
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean docs change

@aslonnie aslonnie removed the request for review from a team August 4, 2023 22:45
@kouroshHakha kouroshHakha changed the title [RLlib] Cherry-pick-learner-docs-263 [RLlib][docs] Cherry-pick-learner-docs-263 Aug 5, 2023
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@avnishn
Copy link
Member Author

avnishn commented Aug 6, 2023

something weird going on with gym/mujoco. Is this expected? do we need to make a fix on the release branch?

@ArturNiederfahrenhorst
Copy link
Contributor

@avnishn Please talk to @can-anyscale . There was an issue on master when we merged Sven's Gym PR. CI would be green and release tests would be red. We applied two forward fixing PRs I believe. @can-anyscale has the most context here def

@avnishn
Copy link
Member Author

avnishn commented Aug 7, 2023

@kouroshHakha can you merge this as is? The tests are failing because of a gym issue that this pr did not cause.

@can-anyscale
Copy link
Collaborator

Is the release branch also failing in the same way or it only fails in this PR?

@kouroshHakha
Copy link
Contributor

@rickyyx should do the pick. Are we gonna pick those changes to make this release branch green? @can-anyscale ??

@can-anyscale
Copy link
Collaborator

Ok, looking at CI jobs, they are pulling from the base master which is broken, which is why all of these tests are failing. This is an CI infrastructure bug/issue.

I think this is fine to merge.

@can-anyscale can-anyscale reopened this Aug 7, 2023
@rickyyx rickyyx merged commit 9a2ecc3 into ray-project:releases/2.6.3 Aug 7, 2023
91 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-code-affected release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants